Feed aggregator
Can a Country Be Too Rich? Norway Is Finding Out
Read more of this story at Slashdot.
Ageing Accelerates at Around Age 50 - Some Organs Faster Than Others
Read more of this story at Slashdot.
Google's New Security Project 'OSS Rebuild' Tackles Package Supply Chain Verification
Read more of this story at Slashdot.
Astronomers Use Black Holes to Pinpoint Earth's Location. But are Phones and Wifi Blocking the View?
Read more of this story at Slashdot.
CodeSOD: An Exert Operation
The Standard Template Library for C++ is… interesting. A generic set of data structures and algorithms was a pretty potent idea. In practice, early implementations left a lot to be desired. Because the STL is a core part of C++ at this point, and widely used, it also means that it's slow to change, and each change needs to go through a long approval process.
Which is why the STL didn't have a ``std::map::containsfunction until the C++20 standard. There were other options. For example, one could usestd::map::count, to count how many times a key appear. Or you could use std::map::findto search for a key. One argument against adding astd::map::containsfunction is thatstd::map::count` basically does the same job and has the same performance.
None of this stopped people from adding their own. Which brings us to Gaetan's submission. Absent a std::map::contains method, someone wrote a whole slew of fieldExists methods, where field is one of many possible keys they might expect in the map.
bool DataManager::thingyExists (string name) { THINGY* l_pTHINGY = (*m_pTHINGY)[name]; if(l_pTHINGY == NULL) { m_pTHINGY->erase(name); return false; } else { return true; } return false; }I've head of upsert operations- an update and insert as the same operation, but this is the first exert- an existence check and an insert in the same operation.
"thingy" here is anonymization. The DataManager contained several of these methods, which did the same thing, but checked a different member variable. Other classes, similar to DataManager had their own implementations. In truth, the original developer did a lot of "it's a class, but everything inside of it is stored in a map, that's more flexible!"
In any case, this code starts by using the [] accessor on a member variable m_pTHINGY. This operator returns a reference to what's stored at that key, or if the key doesn't exist inserts a default-constructed instance of whatever the map contains.
What the map contains, in this case, is a pointer to a THINGY, so the default construction of a pointer would be null- and that's what they check. If the value is null, then we erase the key we just inserted and return false. Otherwise, we return true. Otherotherwise, we return false.
As a fun bonus, if someone intentionally stored a null in the map, this will think the key doesn't exist and as a side effect, remove it.
Gaetan writes:
What bugs me most is the final, useless return.
I'll be honest, what bugs me most is the Hungarian notation on local variables. But I'm long established as a Hungarian notation hater.
This code at least works, which compared to some bad C++, puts it on a pretty high level of quality. And it even has some upshots, according to Gaetan:
On the bright side: I have obtained easy performance boosts by performing that kind of cleanup lately in that particular codebase.
[Advertisement] Picking up NuGet is easy. Getting good at it takes time. Download our guide to learn the best practice of NuGet for the Enterprise.George Lucas Makes First Comic-Con Appearance to Discuss His Upcoming 'Museum of Narrative Art'
Read more of this story at Slashdot.
Easy NTSYNC Arrives For Steam Users With GE-Proton 10.10
Read more of this story at Slashdot.
Tom Lehrer, Satirical Songwriter and Mathematician, Dies at Age 97
Read more of this story at Slashdot.
Huawei Shows Off 384-Chip AI Computing System That Rival Nvidia's Top Product
Read more of this story at Slashdot.
Researchers Quietly Planned a Test to Dim Sunlight Over 3,900 Square Miles
Read more of this story at Slashdot.
VPN Downloads Surge in UK as New Age-Verification Rules Take Effect
Read more of this story at Slashdot.
Is ChatGPT Making You Stupid?
Read more of this story at Slashdot.
'It's DOOM, but You Can Cut, Copy and Paste Opponents'
Read more of this story at Slashdot.
'Fantastic Four' Tops 'Superman' Opening, Second-Largest of the Year
Read more of this story at Slashdot.
To Fight Climate Change, Norway Wants to Become Europe's Carbon Dump
Read more of this story at Slashdot.
Creator of 1995 Phishing Tool 'AOHell' On Piracy, Script Kiddies, and What He Thinks of AI
Read more of this story at Slashdot.
'Chuck E. Cheese' Handcuffed and Arrested in Florida, Charged with Using a Stolen Credit Card
Read more of this story at Slashdot.
'Serious Delays' Hit Satellite Mega-Constellations of China's Starlink Rivals
Read more of this story at Slashdot.
Did a Vendor's Leak Help Attackers Exploit Microsoft's SharePoint Servers?
Read more of this story at Slashdot.
Comic-Con Peeks at New 'Alien' and 'Avatar' Series, Plus 'Predator' and 'Coyote vs. Acme' Movies
Read more of this story at Slashdot.